Skip to content

Commit

Permalink
Revert "Only skip tests on windows, make note about them needing fixing"
Browse files Browse the repository at this point in the history
This reverts commit 8a77695.
  • Loading branch information
dannyfreeman committed Oct 24, 2023
1 parent 599f0f6 commit a4c43c7
Showing 1 changed file with 5 additions and 11 deletions.
16 changes: 5 additions & 11 deletions Eldev
Original file line number Diff line number Diff line change
Expand Up @@ -12,23 +12,17 @@
(eldev-add-extra-dependencies 'runtime '(:package logview :optional t))
(eldev-add-extra-dependencies 'runtime '(:package clojure-ts-mode :optional t))

(defvar clojure-ts-failing-tests
(when (member system-type '(ms-dos windows-nt cygwin))
'("./test/cider-client-tests.el"
"./test/cider-eval-tests.el"))
"Tests that fail when running against clojure-ts-mode. These need to be fixed.
See 'cider-expected-ns returns the namespace matching the given string path'
and 'cider-provide-file can handle multibyte characters'
test results from windows CI run.")

(defvar cider-test-type 'main)
(setf eldev-standard-excludes `(:or ,eldev-standard-excludes
;; Avoid including files in test "projects".
(eldev-pcase-exhaustive cider-test-type
(`main "./test/*/")
(`integration '("./test/" "!./test/integration"))
(`clojure-ts-mode `("./test/*/" "!./test/clojure-ts-mode"
,@clojure-ts-failing-tests))
(`clojure-ts-mode '("./test/*/" "!./test/clojure-ts-mode"
;; 1 test in each of the below files fails
;; when running clojure-ts-mode tests on windows.
"./test/cider-client-tests.el"
"./test/cider-eval-tests.el"))
(`all '("./test/*/" "!./test/integration")))
"test/integration/projects"
;; This file is _supposed_ to be excluded
Expand Down

0 comments on commit a4c43c7

Please sign in to comment.