Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean duplicate define-key at cider-sesman-browser-map #3719

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

conao3
Copy link
Contributor

@conao3 conao3 commented Jun 29, 2024

This keybind first introduced in the commit. There are two lines of key bindings to C-c C-q, probably due to a simple mistake.

Replace this placeholder text with a summary of the changes in your PR.
The more detailed you are, the better.


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • [x]All tests are passing (eldev test)
  • All code passes the linter (eldev lint) which is based on elisp-lint and includes
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)

Thanks!

If you're just starting out to hack on CIDER you might find this section of its
manual
extremely useful.

@conao3
Copy link
Contributor Author

conao3 commented Jun 29, 2024

Or, just remove the line

@bbatsov
Copy link
Member

bbatsov commented Jun 29, 2024

I think it's better to just remove the duplication.

This keybind first introduced in the commit[1].  There are two
lines of key bindings to `C-c C-q`, probably due to a simple
mistake.

[1]: 6a9bc1c
@conao3
Copy link
Contributor Author

conao3 commented Jun 29, 2024

Thanks, @bbatsov!
I just remove duplicate one.

@conao3 conao3 changed the title bind cider-quit C-c M-q at cider-sesman-browser-map clean duplicate define-key at cider-sesman-browser-map Jun 29, 2024
@bbatsov bbatsov merged commit 20f9a8f into clojure-emacs:master Jun 29, 2024
39 checks passed
@bbatsov
Copy link
Member

bbatsov commented Jun 29, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants