Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insufficient require form when creating test.cljc #216

Closed
yatesco opened this issue Aug 27, 2015 · 3 comments
Closed

Insufficient require form when creating test.cljc #216

yatesco opened this issue Aug 27, 2015 · 3 comments
Assignees

Comments

@yatesco
Copy link

yatesco commented Aug 27, 2015

Create src/test/a/b/c_test.cljc and it produces:

(ns a.b.c-test
  (:require [a.b.c :refer :all]
                 [clojure.test :refer :all]))

It would be better if it produced a clic aware test reference, for example:

(ns a.b.c-test
  (:require [a.b.c :refer :all]
                #?(:clj [clojure.test :refer :all]
                     :cljs [cljs.test :refer :all)))  ;; or whatever the correct new cljs namespace is
@expez
Copy link
Member

expez commented Aug 27, 2015

Would be great if you edited the OP with a copy-paste job instead of just linking.

@yatesco
Copy link
Author

yatesco commented Aug 27, 2015

done - apologies @expez, I wasn't sure of the 'etiquette'.

expez added a commit that referenced this issue Aug 27, 2015
There is no :refer :all in cljs:

- Require the ns under test :as sut
- Require clojure.test and cljs.test :as t for symmetry
@expez expez self-assigned this Aug 27, 2015
expez added a commit that referenced this issue Aug 27, 2015
There is no :refer :all in cljs:

- Require the ns under test :as sut
- Require clojure.test and cljs.test :as t for symmetry
@expez expez closed this as completed in b3596c0 Aug 27, 2015
@expez
Copy link
Member

expez commented Aug 27, 2015

Thanks for the report @yatesco. We're in the very early stages of adding support for cljs and cljc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants