Align a nested map

[rfkm]

Run clojure-align against the following code:

{:a {:a :a
     :bbbb :b}
 :bbbb :b}

Then you'll get:

{:a    {:a :a
     :bbbb :b}
 :bbbb :b}

Is this intended behavior?
align-cljlet can do this in one step:

{:a    {:a    :a
        :bbbb :b}
 :bbbb :b}

[bbatsov]

Yeah, there's room for improvement here. @Malabarba will you, please, look into this?

[Malabarba]

Of course!

[rfkm]

Sorry, I lied.
align-cljlet can not do this in one step.
Actually, it requires two steps:

{:a {:a :a
     :bbbb :b}
 :bbbb :b}

{:a    {:a :a
        :bbbb :b}
 :bbbb :b}

{:a    {:a    :a
        :bbbb :b}
 :bbbb :b}

This behavior is acceptable to me. (Of course, it would be nice if the recursive version is optionally available.)
So, the only problem is clojure-align doesn't indent after alignment?

[Malabarba]

So, the only problem is clojure-align doesn't indent after alignment?

Yes, exactly.

[rfkm]

@Malabarba
Great, thanks! I've confirmed the fix works.

However, I've found another problem...

Run clojure-align against the following map:

{:a {:a :a
     :aaaaaaaaaaaaaaaaaaaaaa :a}
 :b {:a :a
     :aa :a}}

Then:

{:a {:a                      :a
     :aaaaaaaaaaaaaaaaaaaaaa :a}
 :b {:a :a  ; <-
     :aa :a}}

It works with the following map:

{:a {:a :a
     :aaaaaaaaaaaa :a}  ; <- decrease the number of `a`
 :b {:a :a
     :aa :a}}

Probably, end passed to clojure--find-sexp-to-align should be a marker?

[bbatsov]

Run clojure-align against the following map:

Btw, it's way more convenient to use TAB to align. In my mind this functionality was always intended to be used like this (smarter indentation versus the needed to realign manually with the explicit command).

[rfkm]

Yeah, the automatic mode is very convenient, but some people seem not to prefer such a code style, so I hesitate to enable it globally.
Maybe I'll use it for my personal project :)

[Malabarba]

Probably, end passed to clojure--find-sexp-to-align should be a marker?

Good catch! :-)

[rfkm]

@Malabarba Thanks a lot!