Move to top level before re-search-backward in clojure-find-ns
#458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The solution seems reasonable to me. Just update the changelog and add a couple of unit tests covering the fix. The CI has been broken for a while for some mysterious reason, but the tests are still runnable locally. |
xiongtx
force-pushed
the
clojure-find-ns
branch
from
5af2e92 to
4af74ac
Compare
xiongtx
changed the title
re-search-backward in clojure-find-nsre-search-backward in clojure-find-ns
|
Update: moving to eol is insufficient, moving to top level (breaking out of the ns form entirely) seems a better solution. |
Moving to top level avoids improper matching behavior due to being in middle of match. Fix clojure-emacs/cider#2100
xiongtx
force-pushed
the
clojure-find-ns
branch
2 times, most recently
from
660d5e1 to
567d734
Compare
Strange indeed. Posted a question on the Emacs StackExchange. |
My guess is this is something to do with Cask, as the error message is from Thanks for the great PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to top level avoids improper matching behavior due to being in middle of match.
Fix clojure-emacs/cider#2100