Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align to recent pcase changes on Emacs master #585

Merged
merged 1 commit into from
Mar 7, 2021
Merged

Align to recent pcase changes on Emacs master #585

merged 1 commit into from
Mar 7, 2021

Conversation

manuel-uberti
Copy link
Contributor

This PR aims to support the recent changes on pcase introduced on Emacs master while keeping backward compatibility.

See #584
And this thread on emacs-devel for the solution proposed by Stefan Monnier


Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):

  • The commits are consistent with our contribution guidelines.
  • You've added tests (if possible) to cover your change(s). Bugfix, indentation, and font-lock tests are extremely important!
  • You've run M-x checkdoc and fixed any warnings in the code you've written.
  • You've updated the changelog (if adding/changing user-visible functionality).
  • You've updated the readme (if adding/changing user-visible functionality).

Thanks!

@manuel-uberti
Copy link
Contributor Author

@bbatsov Sorry about the CircleCI failures, am I missing something?

@manuel-uberti
Copy link
Contributor Author

FWIW, I ran make test and got Ran 264 specs, 0 failed, in 5.54s.

@bbatsov
Copy link
Member

bbatsov commented Mar 4, 2021

@bbatsov Sorry about the CircleCI failures, am I missing something?

Likely something was changed in the images we're using.

@manuel-uberti
Copy link
Contributor Author

manuel-uberti commented Mar 4, 2021

Likely something was changed in the images we're using.

I see. Do you need me to do something else on this PR, then? I mean code-wise, because I wouldn't know how to help with CircleCI. :)

@bbatsov
Copy link
Member

bbatsov commented Mar 7, 2021

I fixed the CI images, so you can push something to your branch and see if the CI passes now.

@manuel-uberti
Copy link
Contributor Author

Done, thank you!

@bbatsov bbatsov merged commit b5c913a into clojure-emacs:master Mar 7, 2021
@bbatsov
Copy link
Member

bbatsov commented Mar 7, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants