Fix imenu with Clojure code in string or comment

[dakra]

Ignore error that's thrown from down-list when called
with point inside a string or comment.

E.g. with code like:

(defn foo []
  (let [a "
(defn b [_]
  (bar {:bla \"bla\"}))"]))

clojure-match-next-def calls down-list with point inside
the string and down-list will throw an user-error with
"This command doesn't work in strings or comments".

---

Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):

• The commits are consistent with our contribution guidelines.
• You've added tests (if possible) to cover your change(s). Bugfix, indentation, and font-lock tests are extremely important!
• You've run M-x checkdoc and fixed any warnings in the code you've written.
• You've updated the changelog (if adding/changing user-visible functionality).
• You've updated the readme (if adding/changing user-visible functionality).

Thanks!

[dakra]

Friendly ping.
Normally would not bump so early but I saw recent activity here and thought this probably just got overlooked by mistake.
If not, all good, take your time :)

[bbatsov]

Can you push again? I see something was broken with the CI back then and I guess that's why I didn't review this PR.

[bbatsov]

I guess some comment here would be useful, otherwise it's really hard to tell why this error needs to be ignored. I'm also a bit worried this might suppress actual errors and complicate the debugging.

[dakra]

I looked a bit more into it why I didn't happen before and nobody noticed.
The change to down-list came only in May with this: https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=0b3b295776ce723885c9997ab26d57314db2a5df

I guess a better workaround would be to wrap it in
unless (ppss-comment-or-string-start (syntax-ppss)) instead of ignore-errors,
but ppss-comment-or-string-start is only available since Emacs 27 and clojure-mode
is marked to support Emacs 25+.

I updated the commit message with this info and added a short comment.
Happy to rephrase it or change something else.

[bbatsov]

If ppss-comment-or-string-start is not complex I guess we can just copy it and inline it.

[dakra]

CircleCI still red because it couldn't find a usable config.yml

[bbatsov]

Ah, CircleCI is killing me these days... Let me try resetting the build token once again. @vemv (or anyone else) - if someone has better ideas what to do about this build issue let me know.

[bbatsov]

@dakra You can try pushing again to see if now the CI will work. I plan to cut a new release soon and it'd be nice for this to make it there.

[dakra]

@bbatsov done. but CircleCI instantly failed again :/

[bbatsov]

@vemv Any idea what's wrong with CircleCI these days? I'm getting progressively more frustrated with it, given the recent OAuth issues that happened for no apparent reason.