Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code cleanup for workflow.clj #22

Closed
wants to merge 3 commits into from
Closed

Conversation

stuarth
Copy link
Contributor

@stuarth stuarth commented May 16, 2014

I was able to trim down the let binding in request-token . merge if you'd like!

@ddellacosta
Copy link
Contributor

@stuarth Sorry I'm slow to respond. I want to include this but I'm doing a bit of refactoring of some related code first, so give me a little bit to get back to you. Thanks for your patience!

add response-parse-fn to config that supersedes access-token-parse-fn
in response-token, allowing more general response parsing to be done
@stuarth
Copy link
Contributor Author

stuarth commented Jun 3, 2014

@ddellacosta no worries! I pushed a bit more code that allows parsing refresh tokens. Whatcha think?

@ddellacosta
Copy link
Contributor

A few comments:

  1. please split up your pull requests so they are small patches each with a specific purpose (i.e. "this refactors code in X sub-system to be cleaner" and "adds parsing refresh tokens" vs. putting everything in "code cleanup for workflow."

  2. if you are adding refresh token parsing make sure you mention/link to handle refresh tokens #20 if you would.

I'm taking a closer look at the refresh token stuff now, but this is great that you've done this work. Many thanks!

@anthgur
Copy link

anthgur commented Jun 28, 2014

Any update on this? I would like to be able to use this project for g+ sso and mirror api stuff. I realized after looking the current workflow source that it doesn't give easy access to refresh tokens, which I need to store for later use.

Thanks!

@ddellacosta
Copy link
Contributor

I've merged in the first commit with a small tweak. Everything else relating to refresh token/token parsing should be discussed in #25, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants