-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for RequestContext during block rendering #15
Conversation
@vintage I think what you're saying is that if you pass a I've been unable to find any documentation for Any thoughts on adding a test for this? |
@clokep That's exactly the case, as right now it's not possible to pass For some reason the newly added test is failing on Travis (works locally), any ideas? |
I've managed to fix the breaking test, but there is still some problem with the Travis itself |
I'll try to fix the issue with travis in a separate branch. |
Hey, got any news about this one? |
Sorry for the extreme delay on this. Overall it looks reasonable. I left a couple of comments, but can always make these changes myself if necessary. Do you know if Jinja has any similar concept to this? |
Also it would be great if we could update the README with some examples / API changes and the changelog too! |
@clokep AFAIK Jinja do not provide any concept near the Django RequestContext. I've also updated the |
Thanks for this improvement! I'll probably try to do a couple minor things before releasing. 👍 |
@vintage FYI I just pushed version 0.6 with this change in it! |
@clokep Awesome, great to hear that <3 |
Thx guys ! |
The current implementation hard-codes use of the
Context
instance, but lots of apps are usingRequestContext
instead - https://docs.djangoproject.com/en/2.0/ref/templates/api/#django.template.RequestContextRefactor context creation to take into account, that both classes are supported by using Django built-in method called
make_context
.