Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace gin to echo #33

Merged

Conversation

jjang-go
Copy link
Contributor

@jjang-go jjang-go commented Nov 24, 2023

@yunkon-kim

  • gin 주석 제거
  • web 테스트

변경사항

  1. ::1 추가
  2. main group 제거 후 initserver()로 이동 - group일때 not found가 지속적으로 생겨서 옮겼습니다.
e := echo.New()

// Middleware
e.Use(middleware.Logger())
e.Use(middleware.Recover())
e.Use(TrustedProxiesMiddleware([]string{"127.0.0.1", "::1"}))

e.Static("/res", "./web")
e.File("/favicon.ico", "./web/assets/favicon.ico")
renderer := &TemplateRenderer{
    templates: template.Must(template.ParseGlob("./web/templates/*.html")),
}
e.Renderer = renderer

e.GET("/", controllers.MainGetHandler)

generateGroup := e.Group("/generate")
routes.GenerateRoutes(generateGroup)

migrationGroup := e.Group("/migration")
routes.MigrationRoutes(migrationGroup)
  1. Test to replace gin to echo #32 에서 언급된 파일 내 함수도 확인하면서 생성 및 마이그레이션 테스트를 하였습니다.

Copy link
Member

@yunkon-kim yunkon-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjang-go LGTM 입니다! 감사합니다.

@yunkon-kim yunkon-kim merged commit dc1756b into cloud-barista:main Nov 24, 2023
2 checks passed
@jjang-go jjang-go deleted the feature/32-replace-gin-to-echo branch November 24, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants