Add Additional tags to Hypershift Clusters #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds following tags to the HyperShift clusters
1) User:${GITHUB_USER}
2) {MGMT_CLUSTER_NAME}:{HOSTED_CLUSTER_NAME}
Signed-off-by: Krishna Harsha Voora <krvoora@redhat.com>
|
Hi @mukrishn as discussed, updated the tags, ptal |
|
@krishvoor @mukrishn @morenod Adding User tag is useful for airflow but probably not so much for e2e. Here, folks usually run from the upstream repo itself and not the fork. So most likely, the User is always |
|
@smalleni I hear you, the original scope of the project was to add tags to track hosted cluster-info. When working with e2e-benchmarking-->hypershift script, we definitely need a way to know which user spun the hosted cluster. |
krishvoor
force-pushed
the
hypershift-tags
branch
from
6bf4046 to
0e9f088
Compare
Signed-off-by: Krishna Harsha Voora <krvoora@redhat.com>
krishvoor
force-pushed
the
hypershift-tags
branch
from
0e9f088 to
dafce00
Compare
mukrishn
approved these changes
Oct 17, 2022
vishnuchalla
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Add Additional tags to Hypershift Clusters
This PR adds following tags to the HyperShift clusters
1) User:${GITHUB_USER}
2) {MGMT_CLUSTER_NAME}:{HOSTED_CLUSTER_NAME}
Signed-off-by: Krishna Harsha Voora <krvoora@redhat.com>
* Updates the tags
Signed-off-by: Krishna Harsha Voora <krvoora@redhat.com>
Signed-off-by: Krishna Harsha Voora <krvoora@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the following tags to the HyperShift clusters
Signed-off-by: Krishna Harsha Voora krvoora@redhat.com