Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hypershift conditionals #503

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Fix hypershift conditionals #503

merged 2 commits into from
Oct 27, 2022

Conversation

rsevilla87
Copy link
Member

Signed-off-by: Raul Sevilla rsevilla@redhat.com

Description

These two conditionals are incorrect and are always evaluated true

@rsevilla87
Fix hypershift conditionals
50de061 
Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
@rsevilla87 rsevilla87 added the bug Something isn't working label Oct 27, 2022
@qiliRedHat
Copy link
Collaborator

@rsevilla87 I tested with your fork/branch, still have some problem

10-27 19:46:40.338  �[1mThu Oct 27 11:46:33 UTC 2022 Disabling cluster version operator�[0m
10-27 19:46:40.338  deployment.apps/cluster-version-operator scaled
10-27 19:46:40.338  common.sh: line 74: !false: command not found
10-27 19:46:40.338  �[1mThu Oct 27 11:46:33 UTC 2022 Using the default ingress-operator image�[0m
10-27 19:46:40.338  �[1mThu Oct 27 11:46:33 UTC 2022 Using the default router image�[0m
10-27 19:46:40.338  �[1mThu Oct 27 11:46:33 UTC 2022 Scaling ingress-operator down to 0�[0m
10-27 19:46:40.338  Error from server (NotFound): deployments.apps "ingress-operator" not found

@rsevilla87
Fix typo
39b8e22 
Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
@rsevilla87
Copy link
Member Author

@rsevilla87 I tested with your fork/branch, still have some problem

10-27 19:46:40.338  �[1mThu Oct 27 11:46:33 UTC 2022 Disabling cluster version operator�[0m
10-27 19:46:40.338  deployment.apps/cluster-version-operator scaled
10-27 19:46:40.338  common.sh: line 74: !false: command not found
10-27 19:46:40.338  �[1mThu Oct 27 11:46:33 UTC 2022 Using the default ingress-operator image�[0m
10-27 19:46:40.338  �[1mThu Oct 27 11:46:33 UTC 2022 Using the default router image�[0m
10-27 19:46:40.338  �[1mThu Oct 27 11:46:33 UTC 2022 Scaling ingress-operator down to 0�[0m
10-27 19:46:40.338  Error from server (NotFound): deployments.apps "ingress-operator" not found

ok, as discussed in Slack, you can try again with the latest bits

smalleni
smalleni approved these changes Oct 27, 2022
View reviewed changes
Copy link
Collaborator

@smalleni smalleni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like bash behaves weirdly with booleans :-)

@mukrishn mukrishn merged commit 7af6e86 into cloud-bulldozer:master Oct 27, 2022
@qiliRedHat
Copy link
Collaborator

I tested with the merged code, it worked well now.

@qiliRedHat qiliRedHat mentioned this pull request Nov 4, 2022
Merged
vishnuchalla pushed a commit that referenced this pull request Sep 6, 2023
@rsevilla87
Fix hypershift conditionals (#503)
b874d25 
* Fix hypershift conditionals

Signed-off-by: Raul Sevilla <rsevilla@redhat.com>

* Fix typo

Signed-off-by: Raul Sevilla <rsevilla@redhat.com>

Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukrishn mukrishn mukrishn approved these changes

@smalleni smalleni smalleni approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rsevilla87 @qiliRedHat @smalleni @mukrishn