Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conc builds update to use python3 #507

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

paigerube14
Copy link
Collaborator

Description

I updated the build_test.py script in the svt repo to use python3 packages instead of python2. Need to update this script to take out python 2 references

Also the eap imagestream name had been updated and the concurrent-build script was not able to properly run that type of build

Fixes

Error "Error resolving ImageStreamTag jboss-eap64-openshift:latest in namespace openshift: imagestreams.image.openshift.io "jboss-eap64-openshift" not found" for field "from".

@comet-perf-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@jtaleric jtaleric added the ok to test Kick off our CI framework label Nov 8, 2022
Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments inline, just curious if we should explicitly call the python version we want/need.

Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jtaleric
Copy link
Member

jtaleric commented Nov 8, 2022

@mohit-sheth

@mohit-sheth mohit-sheth self-requested a review November 9, 2022 14:16
Copy link
Collaborator

@mohit-sheth mohit-sheth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jtaleric jtaleric merged commit da4abca into cloud-bulldozer:master Nov 9, 2022
vishnuchalla pushed a commit that referenced this pull request Sep 6, 2023
* adding no cleanpu

* python and pip 3 versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok to test Kick off our CI framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants