-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add rc 200 and 0 to touchstone config for router-perf and modifying default number of clients #518
add rc 200 and 0 to touchstone config for router-perf and modifying default number of clients #518
Conversation
Can one of the admins verify this patch? |
Test result in this result sheet https://docs.google.com/spreadsheets/d/118stkJ5uzEhYCo8k9F6J0CfkEmepoE1EvCzVxmlhuxM/edit#gid=831215729 |
Hey @qiliRedHat , rather than adding another config file, why don't you add the new comparisons to the original? |
@rsevilla87 If adding to the origin don't impact others, I'm more than happy to do that. |
…update default clients number
5fbbab1
to
893ee4c
Compare
@rsevilla87 PTAL again |
@rsevilla87 Please help to review again. |
@@ -24,13 +24,13 @@ get_scenario(){ | |||
if [[ ${NUM_NODES} -ge ${LARGE_SCALE_THRESHOLD} ]]; then | |||
log "Large scale scenario detected: #workers >= ${LARGE_SCALE_THRESHOLD}" | |||
export NUMBER_OF_ROUTES=${LARGE_SCALE_ROUTES:-500} | |||
CLIENTS=${LARGE_SCALE_CLIENTS:-"1 20 80"} | |||
CLIENTS_MIX=${LARGE_SCALE_CLIENTS_MIX:-"1 10 20"} | |||
CLIENTS=${LARGE_SCALE_CLIENTS:-"1 80"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @mohit-sheth @jtaleric @dry923, changing default number of clients, as per 4.12 maxconns has been upgraded from 20K to 50K. Some context -> #519 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR is to add a touchstone config file to generate results for the 200 and 0 rc codes.
I didn't include all kinds of rc code, because other rc codes are rarely seen, getting all of them can make the results sheet not easy to read.