Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cni and heavy namespaced iterations env. #526

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

afcollins
Copy link
Member

Add postgres readinessProbe that helps performance.

Description

Larger densities of node-density-cni and node-density-heavy workloads benefit from NAMESPACED_ITERATIONS=true.

A readiness probe on postgres helps reduce failure and restarts of the app-deployment.

@afcollins afcollins requested a review from rsevilla87 January 26, 2023 22:44
@@ -25,6 +25,7 @@ case ${WORKLOAD} in
METRICS_PROFILE=${METRICS_PROFILE:-metrics-profiles/metrics.yaml}
NODE_COUNT=${NODE_COUNT:-$(kubectl get node -l ${WORKER_NODE_LABEL},node-role.kubernetes.io/infra!=,node-role.kubernetes.io/workload!= -o name | wc -l)}
PODS_PER_NODE=${PODS_PER_NODE:-245}
export NAMESPACED_ITERATIONS=${NAMESPACED_ITERATIONS:-false}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the docs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Please check.

Add postgres readinessProbe that helps performance.
@afcollins afcollins force-pushed the cni-heavy-namespaced branch from a589065 to 8eb5ec8 Compare February 2, 2023 00:59
@rsevilla87 rsevilla87 self-requested a review February 15, 2023 23:34
Copy link
Member

@rsevilla87 rsevilla87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rsevilla87 rsevilla87 merged commit 0bf6622 into cloud-bulldozer:master Feb 15, 2023
vishnuchalla pushed a commit that referenced this pull request Sep 6, 2023
* Add cni and heavy namespaced iterations env.

Add postgres readinessProbe that helps performance.

* Add docs, fix typo
@afcollins afcollins deleted the cni-heavy-namespaced branch December 21, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants