Cert update to 2048 bit #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
rsevilla87
requested changes
Feb 1, 2023
There was a problem hiding this comment.
Hey @skordas, thanks for the PR!
Rather than providing our own certificate to the ingress controller I think we can use the default ingress certificates:
This can be done by creating an edge route w/o specifying any certificate information. i.e:
kind: Route
apiVersion: route.openshift.io/v1
metadata:
name: {{.name}}-{{.Replica}}
spec:
host: www.{{.name}}.example-{{.Iteration}}-{{.Replica}}.com
to:
kind: Service
name: {{.name}}-{{.Iteration}}-{{.Replica}}
tls:
termination: edge
|
@rsevilla87 Both success |
rsevilla87
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update rsa key to 2048
Fixes
https://issues.redhat.com/browse/OCPBUGS-5521
Current certificate was generated as 1024-bit and the caCertificate was generated as 2048-bit. Both need to be 2048 to work with FIPS