Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare configs for nodeMemoryUtilization-Masters and etcd, crio, kubelet #539

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Compare configs for nodeMemoryUtilization-Masters and etcd, crio, kubelet #539

merged 1 commit into from
Mar 9, 2023

Conversation

paigerube14
Copy link
Collaborator

Description

Want to add comparison config files to be used in collecting more data in runs

@comet-perf-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@vishnuchalla vishnuchalla self-requested a review March 1, 2023 14:53
@vishnuchalla
Copy link
Collaborator

@paigerube14 Can you attach relevant logs/screenshots on how these changes were tested? Thanks.

@paigerube14
Copy link
Collaborator Author

@vishnuchalla I used Qe's jenkins job to run kube burner with these new comparison files

https://mastern-jenkins-csb-openshift-qe.apps.ocp-c1.prod.psi.redhat.com/job/scale-ci/job/e2e-benchmarking-multibranch-pipeline/job/kube-burner/2140/parameters/

COMPARISON_CONFIG=
clusterVersion.json podLatency.json crio.json etcd.json nodeMasters-max.json nodeWorkers.json

02-28 17:27:57.638  ~/ws/workspace/multibranch-pipeline_kube-burner/workloads/kube-burner
02-28 17:27:57.638  �[1mTue Feb 28 22:27:56 UTC 2023 Indexing benchmark metadata to [https://ocp-qe:****@search-ocp-qe-perf-scale-test-elk-hcm7wtsqpxy7xogbu72bor4uve.us-east-1.es.amazonaws.com/ripsaw-kube-burner�[0m](https://ocp-qe:****@search-ocp-qe-perf-scale-test-elk-hcm7wtsqpxy7xogbu72bor4uve.us-east-1.es.amazonaws.com/ripsaw-kube-burner%1B[0m)
02-28 17:27:57.638  �[1mTue Feb 28 22:27:56 UTC 2023 benchmark�[0m
02-28 17:27:57.638  �[1mTue Feb 28 22:27:56 UTC 2023 Installing touchstone�[0m
02-28 17:28:12.600  openshift-sdn
02-28 17:28:12.600  final csv /tmp/node-density-41790c4d-465a-433d-8c8a-1855a9d79bb8/41790c4d-465a-433d-8c8a-1855a9d79bb8.csv
02-28 17:28:12.600  config /home/jenkins/ws/workspace/multibranch-pipeline_kube-burner/utils/touchstone-configs/clusterVersion.json
02-28 17:28:12.600  comparison output
02-28 17:28:12.600  �[1mTue Feb 28 22:28:10 UTC 2023 Querying results�[0m
02-28 17:28:12.600  �[1mTue Feb 28 22:28:10 UTC 2023 Running: touchstone_compare --database elasticsearch -url https://ocp-qe:****@search-ocp-qe-perf-scale-test-elk-hcm7wtsqpxy7xogbu72bor4uve.us-east-1.es.amazonaws.com/ -u 41790c4d-465a-433d-8c8a-1855a9d79bb8 --config /tmp/node-density-41790c4d-465a-433d-8c8a-1855a9d79bb8/clusterVersion.json -o csv --output-file /home/jenkins/ws/workspace/multibranch-pipeline_kube-burner/workloads/kube-burner/node-density-41790c4d-465a-433d-8c8a-1855a9d79bb8.csv�[0m
02-28 17:28:12.600  �[1mTue Feb 28 22:28:11 UTC 2023 python csv modifier�[0m
02-28 17:28:12.600  config /home/jenkins/ws/workspace/multibranch-pipeline_kube-burner/utils/touchstone-configs/podLatency.json
02-28 17:28:12.600  comparison output
02-28 17:28:12.600  �[1mTue Feb 28 22:28:12 UTC 2023 Querying results�[0m
02-28 17:28:12.600  �[1mTue Feb 28 22:28:12 UTC 2023 Running: touchstone_compare --database elasticsearch -url https://ocp-qe:****@search-ocp-qe-perf-scale-test-elk-hcm7wtsqpxy7xogbu72bor4uve.us-east-1.es.amazonaws.com/ -u 41790c4d-465a-433d-8c8a-1855a9d79bb8 --config /tmp/node-density-41790c4d-465a-433d-8c8a-1855a9d79bb8/podLatency.json -o csv --output-file /home/jenkins/ws/workspace/multibranch-pipeline_kube-burner/workloads/kube-burner/node-density-41790c4d-465a-433d-8c8a-1855a9d79bb8.csv�[0m
02-28 17:28:13.397  �[1mTue Feb 28 22:28:13 UTC 2023 python csv modifier�[0m
02-28 17:28:13.958  config /home/jenkins/ws/workspace/multibranch-pipeline_kube-burner/utils/touchstone-configs/crio.json
02-28 17:28:13.958  comparison output
02-28 17:28:13.958  �[1mTue Feb 28 22:28:13 UTC 2023 Querying results�[0m
02-28 17:28:13.958  �[1mTue Feb 28 22:28:13 UTC 2023 Running: touchstone_compare --database elasticsearch -url https://ocp-qe:****@search-ocp-qe-perf-scale-test-elk-hcm7wtsqpxy7xogbu72bor4uve.us-east-1.es.amazonaws.com/ -u 41790c4d-465a-433d-8c8a-1855a9d79bb8 --config /tmp/node-density-41790c4d-465a-433d-8c8a-1855a9d79bb8/crio.json -o csv --output-file /home/jenkins/ws/workspace/multibranch-pipeline_kube-burner/workloads/kube-burner/node-density-41790c4d-465a-433d-8c8a-1855a9d79bb8.csv�[0m
02-28 17:28:15.297  �[1mTue Feb 28 22:28:15 UTC 2023 python csv modifier�[0m
02-28 17:28:15.858  config /home/jenkins/ws/workspace/multibranch-pipeline_kube-burner/utils/touchstone-configs/etcd.json
02-28 17:28:15.858  comparison output
02-28 17:28:15.858  �[1mTue Feb 28 22:28:15 UTC 2023 Querying results�[0m
02-28 17:28:15.858  �[1mTue Feb 28 22:28:15 UTC 2023 Running: touchstone_compare --database elasticsearch -url https://ocp-qe:****@search-ocp-qe-perf-scale-test-elk-hcm7wtsqpxy7xogbu72bor4uve.us-east-1.es.amazonaws.com/ -u 41790c4d-465a-433d-8c8a-1855a9d79bb8 --config /tmp/node-density-41790c4d-465a-433d-8c8a-1855a9d79bb8/etcd.json -o csv --output-file /home/jenkins/ws/workspace/multibranch-pipeline_kube-burner/workloads/kube-burner/node-density-41790c4d-465a-433d-8c8a-1855a9d79bb8.csv�[0m
02-28 17:28:17.314  �[1mTue Feb 28 22:28:16 UTC 2023 python csv modifier�[0m
02-28 17:28:17.569  config /home/jenkins/ws/workspace/multibranch-pipeline_kube-burner/utils/touchstone-configs/nodeMasters-max.json
02-28 17:28:17.569  comparison output
02-28 17:28:17.569  �[1mTue Feb 28 22:28:17 UTC 2023 Querying results�[0m
02-28 17:28:17.569  �[1mTue Feb 28 22:28:17 UTC 2023 Running: touchstone_compare --database elasticsearch -url https://ocp-qe:****@search-ocp-qe-perf-scale-test-elk-hcm7wtsqpxy7xogbu72bor4uve.us-east-1.es.amazonaws.com/ -u 41790c4d-465a-433d-8c8a-1855a9d79bb8 --config /tmp/node-density-41790c4d-465a-433d-8c8a-1855a9d79bb8/nodeMasters-max.json -o csv --output-file /home/jenkins/ws/workspace/multibranch-pipeline_kube-burner/workloads/kube-burner/node-density-41790c4d-465a-433d-8c8a-1855a9d79bb8.csv�[0m
02-28 17:28:18.598  �[1mTue Feb 28 22:28:18 UTC 2023 python csv modifier�[0m
02-28 17:28:19.156  config /home/jenkins/ws/workspace/multibranch-pipeline_kube-burner/utils/touchstone-configs/nodeWorkers.json
02-28 17:28:19.156  comparison output
02-28 17:28:19.156  �[1mTue Feb 28 22:28:19 UTC 2023 Querying results�[0m
02-28 17:28:19.156  �[1mTue Feb 28 22:28:19 UTC 2023 Running: touchstone_compare --database elasticsearch -url https://ocp-qe:****@search-ocp-qe-perf-scale-test-elk-hcm7wtsqpxy7xogbu72bor4uve.us-east-1.es.amazonaws.com/ -u 41790c4d-465a-433d-8c8a-1855a9d79bb8 --config /tmp/node-density-41790c4d-465a-433d-8c8a-1855a9d79bb8/nodeWorkers.json -o csv --output-file /home/jenkins/ws/workspace/multibranch-pipeline_kube-burner/workloads/kube-burner/node-density-41790c4d-465a-433d-8c8a-1855a9d79bb8.csv�[0m
02-28 17:28:20.197  �[1mTue Feb 28 22:28:20 UTC 2023 python csv modifier�[0m
02-28 17:28:20.855  �[1mTue Feb 28 22:28:20 UTC 2023 Installing requirements to generate spreadsheet�[0m
02-28 17:28:23.362  WARNING: You are using pip version 21.1.3; however, version 23.0.1 is available.
02-28 17:28:23.362  You should consider upgrading via the '/tmp/tmp.CQal3kWe2U/bin/python3 -m pip install --upgrade pip' command.
02-28 17:28:23.616  �[1mTue Feb 28 22:28:23 UTC 2023 Sheetname: node-density-2023-02-28T22:28:23�[0m
02-28 17:28:23.616  �[1mTue Feb 28 22:28:23 UTC 2023 CSV: /tmp/node-density-41790c4d-465a-433d-8c8a-1855a9d79bb8/41790c4d-465a-433d-8c8a-1855a9d79bb8.csv�[0m
02-28 17:28:23.616  �[1mTue Feb 28 22:28:23 UTC 2023 Email: prubenda@redhat.com�[0m
02-28 17:28:23.616  �[1mTue Feb 28 22:28:23 UTC 2023 Service-account: /home/jenkins/ws/workspace/multibranch-pipeline_kube-burner/.gsheet.json�[0m
02-28 17:28:31.684  ************** Google Spreadsheet link ---> https://docs.google.com/spreadsheets/d/14J9e_A618NUuMDAtL52vQvHZO0Xrc517HhgWTm6sshQ ***************

@vishnuchalla
Copy link
Collaborator

/lgtm

afcollins
afcollins approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@afcollins afcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afcollins afcollins merged commit d3740b8 into cloud-bulldozer:master Mar 9, 2023
vishnuchalla pushed a commit that referenced this pull request Sep 6, 2023
@paigerube14
normal node information (#539)
058759d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishnuchalla vishnuchalla vishnuchalla approved these changes

@afcollins afcollins afcollins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paigerube14 @comet-perf-ci @vishnuchalla @afcollins