Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up 'compare.sh' and added add'l comments #576

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

nathan-weinberg
Copy link
Contributor

@nathan-weinberg nathan-weinberg commented Jun 14, 2023

Description

The NetObserv team is increasing our usage of compare.sh so wanted to make some contributions to clean up the file a bit and make it easier to potentially extend in the future

Fixes

  • Small typo fix
  • Formatting
  • Adds additional comments
  • Stops CSVs generated in utils directory from being tracked

@paigerube14 paigerube14 self-requested a review June 14, 2023 20:17
Copy link
Collaborator

@paigerube14 paigerube14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtaleric jtaleric added the ok to test Kick off our CI framework label Jun 15, 2023
Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - nothing fundamentally changing.

@jtaleric jtaleric merged commit ac9dce5 into cloud-bulldozer:master Jun 15, 2023
@nathan-weinberg nathan-weinberg deleted the compare-cleanup branch June 15, 2023 21:02
vishnuchalla pushed a commit that referenced this pull request Sep 6, 2023
* Cleaned up 'compare.sh' and added add'l comments

* Stop CSVs from being Git-tracked
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok to test Kick off our CI framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants