Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ingress-perf]: Rename default configuration file #593

Merged

Conversation

krishvoor
Copy link
Member

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

This PR renames the default configuration file

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Signed-off-by: Krishna Harsha Voora <krvoora@redhat.com>
@krishvoor krishvoor requested a review from rsevilla87 July 12, 2023 16:22
Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rsevilla87
Copy link
Member

Make sure to update the airflow config as well @krishvoor
https://github.com/cloud-bulldozer/airflow-kubernetes/blob/master/dags/openshift_nightlies/config/benchmarks/data-plane-v2.json#L24

@krishvoor
Copy link
Member Author

@rsevilla87 rsevilla87 merged commit 25bcc68 into cloud-bulldozer:master Jul 14, 2023
vishnuchalla pushed a commit that referenced this pull request Sep 6, 2023
Signed-off-by: Krishna Harsha Voora <krvoora@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants