Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate legacy kube-burner workload #608

Merged

Conversation

rsevilla87
Copy link
Member

@rsevilla87 rsevilla87 commented Aug 9, 2023

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Deprecation
  • Documentation Update

Description

The workload's on this directory shouldn't be used anymore, people should use https://github.com/cloud-bulldozer/e2e-benchmarking/tree/master/workloads/kube-burner-ocp-wrapper going forward.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

@rsevilla87
Copy link
Member Author

rsevilla87 commented Aug 9, 2023

Please, feel free to tag more affected users.
cc: @mffiedler

@rsevilla87 rsevilla87 requested a review from smalleni August 9, 2023 11:11
Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
@rsevilla87 rsevilla87 force-pushed the deprecate-legacy-kube-burner branch from ea687bf to f980242 Compare August 9, 2023 11:11
@dry923
Copy link
Member

dry923 commented Aug 9, 2023

@rsevilla87 Can we add an estimated removal date or something as well when the directory will be removed?

@jtaleric
Copy link
Member

jtaleric commented Aug 9, 2023

Since this change only removes the CI runs I am good with it... I do think there are teams (ACS in particular) using non-ocp-wrapper kube-burner.

@paigerube14
Copy link
Collaborator

Agree with Joe! Think it's ok to remove ci references. Not sure if we are fully ready (qe) side for a full removal of kube burner folder

@rsevilla87
Copy link
Member Author

rsevilla87 commented Aug 9, 2023

Agree with Joe! Think it's ok to remove ci references. Not sure if we are fully ready (qe) side for a full removal of kube burner folder

Thanks for the feedback!, as @dry923 also suggested, we should maybe add an EOL date so we can definitively remove the kube-burner directory.
I'll add October as EOL (remove) for this directory, if you agree.

@rsevilla87 rsevilla87 merged commit ae79591 into cloud-bulldozer:master Jan 12, 2024
@rsevilla87 rsevilla87 deleted the deprecate-legacy-kube-burner branch February 19, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants