Update hypershift on aks to calculate the token #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morenod
force-pushed
the
azure_prometheus_token
branch
from
36d8bb8 to
1e0c66d
Compare
Signed-off-by: morenod <dsanzmor@redhat.com>
morenod
force-pushed
the
azure_prometheus_token
branch
from
1e0c66d to
4cfbac4
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krishvoor, morenod, mukrishn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 944e4bb
into
cloud-bulldozer:master
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Create the token inside the script to avoid expiration
Related Tickets & Documents
Checklist before requesting a review
Testing