Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates the WORKLOAD condition #724

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Updates the WORKLOAD condition #724

merged 1 commit into from
Oct 8, 2024

Conversation

krishvoor
Copy link
Member

This PR would bypass updating iterations if the WORKLOAD is udn-density-l3-pods

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Adds udn-density-l3-pods to WORKLOAD Logic

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@krishvoor
Updates the WORKLOAD condition
4f5b22e 
This PR would bypass updating iterations if the WORKLOAD
is udn-density-l3-pods

Signed-off-by: Krishna Harsha Voora <krvoora@redhat.com>
@openshift-ci openshift-ci bot added the approved label Oct 3, 2024
@krishvoor krishvoor changed the title Updates the WORKLOAD condition [WIP] Updates the WORKLOAD condition Oct 3, 2024
@krishvoor
Copy link
Member Author

/hold

@krishvoor krishvoor changed the title [WIP] Updates the WORKLOAD condition Updates the WORKLOAD condition Oct 3, 2024
@krishvoor
Copy link
Member Author

/unhold

@krishvoor krishvoor mentioned this pull request Oct 3, 2024
Merged
@krishvoor
Copy link
Member Author

Works CI Job: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/57161/rehearse-57161-pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.18-nightly-x86-udn-density-l3-pods-24nodes/1841666847351508992

venkataanil
venkataanil approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@venkataanil venkataanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Oct 8, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krishvoor, venkataanil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [krishvoor,venkataanil]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 300b777 into cloud-bulldozer:master Oct 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@venkataanil venkataanil venkataanil approved these changes

@jtaleric jtaleric Awaiting requested review from jtaleric

@vishnuchalla vishnuchalla Awaiting requested review from vishnuchalla

@mohit-sheth mohit-sheth Awaiting requested review from mohit-sheth

Assignees

@venkataanil venkataanil

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krishvoor @venkataanil