-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements for workers-scale #732
Enhancements for workers-scale #732
Conversation
Signed-off-by: Vishnu Challa <vchalla@vchalla-thinkpadp1gen2.rmtusnc.csb>
de7d49e
to
49740a1
Compare
/test ? |
@vishnuchalla: The following commands are available to trigger required jobs:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test e2e-cluster-density-v2-single-node |
@@ -124,7 +124,6 @@ download_binary | |||
if [[ ${WORKLOAD} =~ "index" || ${WORKLOAD} =~ "workers-scale" ]]; then | |||
if [[ "$START_TIME" != 0 && "$END_TIME" != 0 ]]; then | |||
JOB_START=$(date -u -d "@$START_TIME" +"%Y-%m-%dT%H:%M:%SZ") | |||
END_TIME=$(expr $END_TIME + 600) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You removed this line, but the variable is used below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still its valid and the variable is present. We are just removing the 10 minutes add at the end.
/hold |
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dry923, vishnuchalla The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0fe179d
into
cloud-bulldozer:master
Type of change
Description
Adding enhancements for workers scale and in for kube-burner in overall. Has all the changes incorporated in this PR: kube-burner/kube-burner-ocp#136 as part of the release.
Checklist before requesting a review
Testing
Will be verified through PR rehearsal jobs.