Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements for workers-scale #732

Merged

Conversation

vishnuchalla
Copy link
Collaborator

@vishnuchalla vishnuchalla commented Oct 31, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Adding enhancements for workers scale and in for kube-burner in overall. Has all the changes incorporated in this PR: kube-burner/kube-burner-ocp#136 as part of the release.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

Will be verified through PR rehearsal jobs.

Signed-off-by: Vishnu Challa <vchalla@vchalla-thinkpadp1gen2.rmtusnc.csb>
@vishnuchalla
Copy link
Collaborator Author

/test ?

Copy link

openshift-ci bot commented Oct 31, 2024

@vishnuchalla: The following commands are available to trigger required jobs:

  • /test e2e-cluster-density-v2-single-node
  • /test e2e-conc-builds-single-node
  • /test e2e-ingress-perf-single-node
  • /test e2e-network-policy-single-node
  • /test e2e-network-smoke-single-node
  • /test e2e-node-density-cni-single-node
  • /test e2e-node-density-heavy-single-node
  • /test e2e-node-density-single-node
  • /test e2e-router-perf-single-node

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vishnuchalla
Copy link
Collaborator Author

/test e2e-cluster-density-v2-single-node
/test e2e-conc-builds-single-node
/test e2e-network-policy-single-node
/test e2e-node-density-cni-single-node
/test e2e-node-density-heavy-single-node
/test e2e-node-density-single-node

@@ -124,7 +124,6 @@ download_binary
if [[ ${WORKLOAD} =~ "index" || ${WORKLOAD} =~ "workers-scale" ]]; then
if [[ "$START_TIME" != 0 && "$END_TIME" != 0 ]]; then
JOB_START=$(date -u -d "@$START_TIME" +"%Y-%m-%dT%H:%M:%SZ")
END_TIME=$(expr $END_TIME + 600)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You removed this line, but the variable is used below.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still its valid and the variable is present. We are just removing the 10 minutes add at the end.

@vishnuchalla
Copy link
Collaborator Author

/hold

@vishnuchalla
Copy link
Collaborator Author

/unhold

Copy link
Member

@dry923 dry923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Nov 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dry923, vishnuchalla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dry923,vishnuchalla]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0fe179d into cloud-bulldozer:master Nov 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants