Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure MC name as parameter because of kubectl context #35

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

morenod
Copy link
Collaborator

@morenod morenod commented Nov 22, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

We were obtained the management cluster name from the context of the kubeconfig file, but this context has changed on the last version.

Adding as parameter, as getting on that way was not the perfect solution, and may introduce errors if it changes again in the future

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

@mukrishn
Copy link
Collaborator

lgtm

@mukrishn mukrishn merged commit 08cd293 into cloud-bulldozer:main Dec 18, 2024
1 of 3 checks passed
@morenod morenod deleted the az_mc_name branch December 19, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants