Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create namespace/sa/rolebinding #133

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Create namespace/sa/rolebinding #133

merged 1 commit into from
Feb 29, 2024

Conversation

jtaleric
Copy link
Member

@jtaleric jtaleric commented Feb 19, 2024 •
edited
Loading

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Caving and finally adding the code to create the namespace, service account and role binding to allow for hostNetwork.

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@rsevilla87 rsevilla87 self-requested a review February 20, 2024 15:16
@rsevilla87 rsevilla87 added the enhancement New feature or request label Feb 20, 2024
Create namespace/sa/rolebinding
d37f851 
Caving and finally adding the code to create the namespace, service
account and role binding to allow for `hostNetwork`.

Signed-off-by: Joe Talerico <rook@redhat.com>
@jtaleric jtaleric requested a review from rsevilla87 February 22, 2024 20:10
rsevilla87
rsevilla87 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@rsevilla87 rsevilla87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit weird it works fine with k8s, I guess we're missing something about kind roles/rolebindings, anyway, if it works with OpenShift lgtm

We can fix other potential issues with other distributions in future commits.

@jtaleric jtaleric merged commit f29a9f9 into cloud-bulldozer:main Feb 29, 2024
5 checks passed
@jtaleric jtaleric deleted the create_namespaces branch February 29, 2024 14:18
@jtaleric jtaleric mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsevilla87 rsevilla87 rsevilla87 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFE] Create namespaces
2 participants
@jtaleric @rsevilla87