Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable parallelism in pod 2 service #134

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

rsevilla87
Copy link
Member

@rsevilla87 rsevilla87 commented Feb 22, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Migrated drivers:

  • netperf
  • iperf3
  • uperf

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

---
$ cat netperf.yml
tests:
  - TCPStream:
    parallelism: 2
    profile: "TCP_STREAM"
    duration: 10
    samples: 1
    messagesize: 1024
    service: true

  - TCPStream4:
    parallelism: 4
    profile: "TCP_STREAM"
    duration: 10
    samples: 1
    messagesize: 1024
    service: true

  - UDPStream:
    parallelism: 4
    profile: "UDP_STREAM"
    duration: 10
    samples: 1
    messagesize: 1024
    service: true

$ ./bin/amd64/k8s-netperf --iperf=true --uperf=true --netperf=true                           
blabla
+-------------------+---------+------------+-------------+--------------+---------+--------------+-----------+----------+---------+--------------------+--------------------------+
|    RESULT TYPE    | DRIVER  |  SCENARIO  | PARALLELISM | HOST NETWORK | SERVICE | MESSAGE SIZE | SAME NODE | DURATION | SAMPLES |     AVG VALUE      | 95% CONFIDENCE INTERVAL  |
+-------------------+---------+------------+-------------+--------------+---------+--------------+-----------+----------+---------+--------------------+--------------------------+
| 📊 Stream Results | netperf | TCP_STREAM | 2           | false        | true    | 1024         | false     | 10       | 1       | 9563.330000 (Mb/s) | 0.000000-0.000000 (Mb/s) |
| 📊 Stream Results | iperf3  | TCP_STREAM | 2           | false        | true    | 1024         | false     | 10       | 1       | 9729.428480 (Mb/s) | 0.000000-0.000000 (Mb/s) |
| 📊 Stream Results | uperf   | TCP_STREAM | 2           | false        | true    | 1024         | false     | 10       | 1       | 9709.381217 (Mb/s) | 0.000000-0.000000 (Mb/s) |
| 📊 Stream Results | netperf | TCP_STREAM | 4           | false        | true    | 1024         | false     | 10       | 1       | 12098.420000 (Mb/s) | 0.000000-0.000000 (Mb/s) |
| 📊 Stream Results | iperf3  | TCP_STREAM | 4           | false        | true    | 1024         | false     | 10       | 1       | 12199.460864 (Mb/s) | 0.000000-0.000000 (Mb/s) |
| 📊 Stream Results | uperf   | TCP_STREAM | 4           | false        | true    | 1024         | false     | 10       | 1       | 12182.172435 (Mb/s) | 0.000000-0.000000 (Mb/s) |
| 📊 Stream Results | netperf | UDP_STREAM | 4           | false        | true    | 1024         | false     | 10       | 1       | 6398.070000 (Mb/s) | 0.000000-0.000000 (Mb/s) |
| 📊 Stream Results | iperf3  | UDP_STREAM | 4           | false        | true    | 1024         | false     | 10       | 1       | 6542.152704 (Mb/s) | 0.000000-0.000000 (Mb/s) |
| 📊 Stream Results | uperf   | UDP_STREAM | 4           | false        | true    | 1024         | false     | 10       | 1       | 8490.306765 (Mb/s) | 0.000000-0.000000 (Mb/s) |
+-------------------+---------+------------+-------------+--------------+---------+--------------+-----------+----------+---------+--------------------+--------------------------+
                                          

pkg/k8s/kubernetes.go Outdated Show resolved Hide resolved
@rsevilla87 rsevilla87 added the enhancement New feature or request label Feb 22, 2024
@rsevilla87 rsevilla87 requested review from venkataanil and jtaleric and removed request for venkataanil February 22, 2024 10:37
@rsevilla87 rsevilla87 force-pushed the issue-132 branch 2 times, most recently from d6094aa to 2ac5e86 Compare February 22, 2024 11:57
Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Lets get the image moved back, and when we merge the docker image should be updated... but let me double check

@jtaleric
Copy link
Member

lgtm! Lets get the image moved back, and when we merge the docker image should be updated... but let me double check

Nope... Need to get the action back in shape.

Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor nit before we merge @rsevilla87

pkg/k8s/kubernetes.go Show resolved Hide resolved
Signed-off-by: Raul Sevilla <rsevilla@redhat.com>

Default image location

Signed-off-by: Raul Sevilla <rsevilla@redhat.com>

Update docs

Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
@rsevilla87 rsevilla87 force-pushed the issue-132 branch 3 times, most recently from e77e7f0 to 819d344 Compare March 1, 2024 15:37
@jtaleric jtaleric merged commit 2cd1863 into cloud-bulldozer:main Mar 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] Parallelism in pod 2 service scenarios
2 participants