Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix container and manifest targets in makefile #137

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Fix container and manifest targets in makefile #137

merged 1 commit into from
Mar 1, 2024

Conversation

rsevilla87
Copy link
Member

@rsevilla87 rsevilla87 commented Mar 1, 2024 •
edited
Loading

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Some targets are broken:

  • CONTAINER_NS doesn't is concatenated with $(BIN)
  • There's no need to use the flat -t when building a manifest with multiple platforms/archs
  • Adding the tag :latest to the container image, it's automatically added, but is helps on readability

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.
  • gha-push location was incorrect

@rsevilla87 rsevilla87 requested review from jtaleric and krishvoor March 1, 2024 12:22
@rsevilla87 rsevilla87 force-pushed the fix-makefile branch 3 times, most recently from 512d9bb to 696ce22 Compare March 1, 2024 12:25
@rsevilla87
Fix container and manifest targets in makefile
0747f5e 
Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
krishvoor
krishvoor approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@krishvoor krishvoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

jtaleric
jtaleric approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally -- didn't test any of the multi-arch... but worked for x86.

@jtaleric jtaleric merged commit 770b84b into cloud-bulldozer:main Mar 1, 2024
5 checks passed
@rsevilla87 rsevilla87 deleted the fix-makefile branch March 1, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishvoor krishvoor krishvoor approved these changes

@jtaleric jtaleric jtaleric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rsevilla87 @jtaleric @krishvoor