Adding support of UDN usage #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtaleric
reviewed
Nov 4, 2024
jtaleric
reviewed
Nov 4, 2024
jtaleric
reviewed
Nov 4, 2024
|
https://redhat-internal.slack.com/archives/C077NGF5HE1/p1728676760441059 - I wonder if the annotation will eventually get better? |
jtaleric
reviewed
Nov 4, 2024
|
@jtaleric @rsevilla87 should we do more tests or can we merge this change? |
jtaleric
reviewed
Nov 7, 2024
jtaleric
reviewed
Nov 7, 2024
Using the UDN ip from the Server pod annotations. Service and IPv6 are not supported Using --udn option create a UserDefinedNetwork object on the netperf ns
|
@jtaleric @rsevilla87 did you have the time to take a look at it? |
rsevilla87
reviewed
Nov 13, 2024
rsevilla87
reviewed
Nov 13, 2024
|
@rsevilla87 @jtaleric I have updated the PR. Sorry for the late response, I had no OCP cluster to test the change last week. |
|
@rsevilla87 @jtaleric is it okay to merge this? My next step would be to add the UDN support for VMs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using --udn option create a UserDefinedNetwork object on the netperf ns
Type of change
Description
This new option deploys a UDN network in the netperf Namespace. All the pods are using the UDN interface to contact each other.
It does not support Service and IPv6 (even if the implementation of v6 looks straightforward).
It uses the CRD
userdefinednetworksand not a NAD to create the UDN interfaces on the pods.Related Tickets & Documents
Checklist before requesting a review
Testing