Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding sample readout configs for control plane tests #34

Merged
merged 1 commit into from
May 29, 2024
Merged

Adding sample readout configs for control plane tests #34

merged 1 commit into from
May 29, 2024

Conversation

vishnuchalla
Copy link
Collaborator

@vishnuchalla vishnuchalla commented May 12, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Adding new configs for some of the standard control plane metrics for readout testing.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

Tested them locally and could see results for 4.16

@vishnuchalla
Copy link
Collaborator Author

cc: @mohit-sheth to add similar configs for data-path tests.
As a future action item, we need to convert these as templates and configurable at the runtime to be reusable. Feel free to add more thoughts. Thank you.

Signed-off-by: KBOCPDocs <vishnuchalla47@gmail.com>
@shashank-boyapally
Copy link
Contributor

Thank you for the contribution @vishnuchalla. Been looking for this comprehensive coverage config.

Copy link
Contributor

@mohit-sheth mohit-sheth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for now, will help with jedi work
can even add this as a prow job to run at the end of the week and publish a report

@vishnuchalla
Copy link
Collaborator Author

vishnuchalla commented May 13, 2024

cc: @paigerube14 might be helpful for the prow poc work you are upto.

Copy link
Collaborator

@paigerube14 paigerube14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@paigerube14
Copy link
Collaborator

cc: @paigerube14 might be helpful for the prow poc work you are upto.

yes, thank you. Will need to add the internal es instance set up in prow

@shashank-boyapally
Copy link
Contributor

/lgtm

@dry923 dry923 merged commit 32a011e into cloud-bulldozer:main May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants