add collapse in junit as a table, rename metrics in readout #50
Conversation
Signed-off-by: Shashank Reddy Boyapally <sboyapal@redhat.com>
Signed-off-by: Shashank Reddy Boyapally <sboyapal@redhat.com>
pkg/utils.py
Outdated
| testsuite.set("failures", str(failures_count)) | ||
| testsuite.set("tests", str(test_count)) | ||
| xml_str = ET.tostring(testsuites, encoding="utf8", method="xml").decode() | ||
| dom = xml.dom.minidom.parseString(xml_str) | ||
| pretty_xml_as_string = dom.toprettyxml() | ||
| return pretty_xml_as_string | ||
|
|
||
| def generate_tabular_output(data: dict, metric_name: str) -> str: |
There was a problem hiding this comment.
I think we should just present in the XML a csv -- uuid, buildURL, metric, value, change-point[true|false] not sure how the XML file will read in the table view.
| testcase = ET.SubElement(testsuite, "testcase", name=f"{label_string} {metric} regression detection", timestamp=str(int(datetime.now().timestamp()))) | ||
| if [run for run in data_json if not run["metrics"][metric]["percentage_change"] == 0]: | ||
| failures_count +=1 | ||
| failure = ET.SubElement(testcase,"failure") |
There was a problem hiding this comment.
I wonder if we can reduce the output here, to be where the change-point was seen, with 1 value after and 1 before. wdyt? would cleanup the output quite a bit.
There was a problem hiding this comment.
Yeah, I felt the same that the output was too verbose, we can just have one before and after.
There was a problem hiding this comment.
yeah, quite honestly, with how we plan to run this in CPT I doubt it will be as verbose. but, just to be careful ;)
|
made shorter. |
Signed-off-by: Shashank Reddy Boyapally <sboyapal@redhat.com>
Ok, I like this! Lets ask the TRT team about the format, i wonder if they will want something more like : Might be super nitpicky, but lets ask! Nice work!! |
|
Nice changes @shashank-boyapally . Can you keep the visuals in description updated as well? |
Signed-off-by: Shashank Reddy Boyapally <sboyapal@redhat.com>
|
I have made some changes on how the table should render based on the comments provided by the trt team and updated comment. |
Type of change
Description
The trt team requested to have the metric test in a single testcase and I renamed the metrics in the readout config. Please ignore linting.
Related Tickets & Documents
Checklist before requesting a review
Testing