Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit 1 on regression detection #57

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Exit 1 on regression detection #57

merged 1 commit into from
Sep 9, 2024

Conversation

shashank-boyapally
Copy link
Contributor

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

The cmd will exit with status 1 on detection of regression. Merge after #56

(venv) sboyapal orion (exit-1) >> echo $?
1

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@shashank-boyapally
added regression flag to exit 1 in event of regression
070bd4d 
Signed-off-by: Shashank Reddy Boyapally <sboyapal@redhat.com>
@shashank-boyapally shashank-boyapally mentioned this pull request Aug 19, 2024
Merged
7 tasks
@paigerube14 paigerube14 mentioned this pull request Aug 26, 2024
Merged
7 tasks
@shashank-boyapally shashank-boyapally marked this pull request as ready for review September 9, 2024 15:14
jtaleric
jtaleric approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't tested, but lgtm!

vishnuchalla
vishnuchalla approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@vishnuchalla vishnuchalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vishnuchalla vishnuchalla merged commit fdd566b into cloud-bulldozer:main Sep 9, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishnuchalla vishnuchalla vishnuchalla approved these changes

@jtaleric jtaleric jtaleric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shashank-boyapally @jtaleric @vishnuchalla