Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CI tests #59

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Adding CI tests #59

merged 1 commit into from
Aug 7, 2024

Conversation

vishnuchalla
Copy link
Collaborator

@vishnuchalla vishnuchalla commented Aug 1, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Adding CI tests for orion. They will be triggered against each PR and will help us catch issues early.

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

Tested in local. Attempting to test it from the PR as well.

@vishnuchalla vishnuchalla mentioned this pull request Aug 1, 2024
7 tasks
@vishnuchalla vishnuchalla force-pushed the ci-tests branch 10 times, most recently from 559551a to d6b9918 Compare August 2, 2024 00:08
@vishnuchalla
Copy link
Collaborator Author

@jtaleric @shashank-boyapally @paigerube14 PTAL 👋🏼 . All the payloads are working. We can add/update more scenarios in the follow up PRs if needed.

Signed-off-by: Vishnu Challa <vchalla@vchalla-thinkpadp1gen2.rmtusnc.csb>
@vishnuchalla
Copy link
Collaborator Author

While cutting the release for this change, we need to make sure that appropriate ENVs are populated in prow that fit in with the updated configs.

@shashank-boyapally
Copy link
Contributor

/lgtm

Copy link
Collaborator

@paigerube14 paigerube14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks!

@jtaleric jtaleric merged commit 08cef10 into main Aug 7, 2024
4 checks passed
@jtaleric jtaleric deleted the ci-tests branch August 7, 2024 12:46
jtaleric pushed a commit to jtaleric/orion that referenced this pull request Sep 13, 2024
Signed-off-by: Vishnu Challa <vchalla@vchalla-thinkpadp1gen2.rmtusnc.csb>
Co-authored-by: Vishnu Challa <vchalla@vchalla-thinkpadp1gen2.rmtusnc.csb>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants