chore: release on tag #4208

drewbo · 2023-07-27T15:45:29Z

Changes proposed in this pull request:

This PR removes the git-branch and product instance variables and explicitly defines three different CI pipelines for this repo:
- pipeline-dev.yml: largely the same as before with modularized task definitions (added to ci/partials). The yarn build-dev command was removed in favor of using NODE_ENV to define the build changes and that same env variable is passed to the admin client build as well.
- pipeline-staging.yml: the same as before but with modularized task definitions from above. The deploy-env is removed from the names of PR tests here because they are now deploy env independent.
- pipeline-production.yml: removes the testing of PRs (since all PRs to main are tested in the prior pipeline). Incorporates the release PR management which was previously added as a separate pipeline

security considerations

None

svenaas · 2023-07-31T17:49:19Z

DEVELOPMENT.md

@@ -163,7 +163,7 @@ To deploy to CloudFoundry submit the following:
 `cf push federalistapp --strategy rolling --vars-file "./.cloudgov/vars/${CF_SPACE}.yml" -f ./cloudgov/manifest.yml`

 ### Continuous Integration
-We are in the process of migrating from CircleCI to an internal instance of Concourse CI, starting with our staging environment. To use Concourse, one must have appropriate permissions in UAA as administered by the cloud.gov operators. Access to Concourse also requires using the GSA VPN.
+Our continuous integration pipeline is run on Concourse CI. To use Concourse, one must have appropriate permissions in UAA as administered by the cloud.gov operators. Access to Concourse also requires using the GSA VPN.


Access to Concourse also requires using the GSA VPN.

Maybe it's beyond the scope of this documentation, but Zscaler changes this, or is at least in the process of doing so.

svenaas

Made some copyediting suggestions.

DEVELOPMENT.md

svenaas · 2023-07-31T17:52:01Z

DEVELOPMENT.md

@@ -202,7 +205,7 @@ Some credentials in this pipeline are "compound" credentials that use the pipeli
 --- | --- | --- |
 |**`((deploy-env))-cf-username`**|The deployment environments CloudFoundry deployer username based on the instanced pipeline|:white_check_mark:|


Either "development environment's" or "development environment".

Skipping these because they aren't part of this PR (will catch on a larger docs review)

svenaas · 2023-07-31T17:52:08Z

DEVELOPMENT.md

@@ -202,7 +205,7 @@ Some credentials in this pipeline are "compound" credentials that use the pipeli
 --- | --- | --- |
 |**`((deploy-env))-cf-username`**|The deployment environments CloudFoundry deployer username based on the instanced pipeline|:white_check_mark:|
 |**`((deploy-env))-cf-username`**|The deployment environments CloudFoundry deployer password based on the instanced pipeline|:white_check_mark:|


Either "development environment's" or "development environment".

apburnes

Looks really good and much easier to read. The partials should work out well. Added a couple of comments and questions for clarification. Overall all a great step in the right direction.

ci/pipeline-dev.yml

ci/pipeline-production.yml

apburnes · 2023-08-01T15:52:23Z

webpack.production.config.js

Was this update related to CI tasks or clean up you came across?

It's related: we previously had two commands yarn build and yarn build-dev with slightly different webpack configs. This was introduced to support the dev build options like nicer error tracing. To modularize the task, I wanted to share the same command (now encapsulated as a task in ci/partials/build-api.yml) and webpack config file but configure the differences with an environment variable (NODE_ENV).

Separately, I think it would be even better practice to combine development and production webpack configs into one file and make it even clearer how environment variables swap between different options but I decided that was out of scope for this PR.

This is of immediate interest to me because of #4191. I noticed that build-dev exists but isn't utilized in test:prepare. Also we have both webpack.development-build.config.js (used by build-dev) and webpack.development.config.js (not referenced at all in package.json).

For #4191 I've been considering whether we might need a separate webpack config when building for local testing in order to have a different output folder from what we use on the hosted instances.

@svenaas build-dev is specifically for the concourse dev deploy. webpack.development.config.js is used during our local build (but is included via middleware, not via --config in the CLI)

@drewbo thanks for the clarification. Let me know if we want to flesh out an issue to combine the webpack configs.

apburnes

There's a lot here but the structure solid and dev ci is working as expected. Thanks for handling this work!

Related issue: cloud-gov/product#2563

N/A

drewbo force-pushed the chore-release-on-tag branch from 855e512 to f28878e Compare July 27, 2023 17:49

rcgottlieb approved these changes Jul 28, 2023

View reviewed changes

drewbo force-pushed the chore-release-on-tag branch 2 times, most recently from d981cff to 4b6ac55 Compare July 31, 2023 16:48

drewbo requested a review from a team July 31, 2023 17:25

svenaas reviewed Jul 31, 2023

View reviewed changes

svenaas previously requested changes Jul 31, 2023

View reviewed changes

apburnes self-requested a review August 1, 2023 14:48

apburnes reviewed Aug 1, 2023

View reviewed changes

drewbo changed the base branch from staging to main August 1, 2023 16:14

svenaas mentioned this pull request Aug 1, 2023

Fix dev tests to not build assets in version controlled directory #4191

Closed

3 tasks

apburnes self-requested a review August 1, 2023 19:20

apburnes approved these changes Aug 1, 2023

View reviewed changes

drewbo changed the base branch from main to staging August 1, 2023 19:48

drewbo changed the base branch from staging to main August 1, 2023 19:49

chore: create new production deployment on tag

4e7a4b6

Related issue: cloud-gov/product#2563

drewbo force-pushed the chore-release-on-tag branch from 43ee777 to 4e7a4b6 Compare August 1, 2023 19:58

drewbo merged commit 3283259 into main Aug 1, 2023
3 checks passed

drewbo deleted the chore-release-on-tag branch August 1, 2023 20:08

drewbo mentioned this pull request Aug 3, 2023

Switch production deploys from branch based to release based. #4162

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: release on tag #4208

chore: release on tag #4208

drewbo commented Jul 27, 2023 •

edited

Loading

svenaas Jul 31, 2023

svenaas left a comment

svenaas Jul 31, 2023

drewbo Aug 1, 2023

svenaas Jul 31, 2023

apburnes left a comment

apburnes Aug 1, 2023

drewbo Aug 1, 2023

svenaas Aug 1, 2023

svenaas Aug 1, 2023

drewbo Aug 1, 2023

apburnes Aug 1, 2023

apburnes left a comment

		@@ -202,7 +205,7 @@ Some credentials in this pipeline are "compound" credentials that use the pipeli
		--- \| --- \| --- \|
		\|`((deploy-env))-cf-username`\|The deployment environments CloudFoundry deployer username based on the instanced pipeline\|:white_check_mark:\|

chore: release on tag #4208

chore: release on tag #4208

Conversation

drewbo commented Jul 27, 2023 • edited Loading

Changes proposed in this pull request:

security considerations

Choose a reason for hiding this comment

svenaas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

apburnes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

apburnes left a comment

Choose a reason for hiding this comment

drewbo commented Jul 27, 2023 •

edited

Loading