Merge pull request #824 from duglin/issue820

Avoid int parsing overflow issues
cloudevents · Dec 8, 2022 · 2298be0 · 2298be0
2 parents f0c10d8 + a85b4de
commit 2298be0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/sql/v2/parser/expression_visitor.go b/sql/v2/parser/expression_visitor.go
@@ -277,7 +277,7 @@ func (v *expressionVisitor) VisitStringLiteral(ctx *gen.StringLiteralContext) in
 }
 
 func (v *expressionVisitor) VisitIntegerLiteral(ctx *gen.IntegerLiteralContext) interface{} {
-	val, err := strconv.Atoi(ctx.GetText())
+	val, err := strconv.ParseInt(ctx.GetText(), 10, 32)
 	if err != nil {
 		v.parsingErrors = append(v.parsingErrors, err)
 	}

diff --git a/sql/v2/utils/casting.go b/sql/v2/utils/casting.go
@@ -34,7 +34,7 @@ func Cast(val interface{}, target cesql.Type) (interface{}, error) {
 	case cesql.IntegerType:
 		switch val.(type) {
 		case string:
-			v, err := strconv.Atoi(val.(string))
+			v, err := strconv.ParseInt(val.(string), 10, 32)
 			if err != nil {
 				err = fmt.Errorf("cannot cast from String to Integer: %w", err)
 			}