Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github workflows and Go dependencies #1105

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

embano1
Copy link
Member

@embano1 embano1 commented Oct 20, 2024

This PR updates the Github workflows and Go dependencies to more recent versions:

  • Bump go directive in respective modules to go 1.22
  • Github workflows run with latest Go version (fixed to current 1.23)
  • Update linter and fix errors
  • Update README to indicate tested Go version for this SDK

Note that I didn't feel the need to bump modules straight to go 1.23 because we don't use the latest language features and go 1.22 seemed sufficient/causing less compatibility issues (or warnings) for users < Go 1.22.

@embano1 embano1 force-pushed the deps_go122 branch 4 times, most recently from bd11d6c to f647779 Compare October 20, 2024 07:12
@embano1 embano1 changed the title chore: update workflows and deps to go 1.22 Update Github workflows and Go dependencies Oct 20, 2024
@embano1 embano1 marked this pull request as ready for review October 20, 2024 07:32
@embano1 embano1 requested a review from a team as a code owner October 20, 2024 07:32
@embano1
Copy link
Member Author

embano1 commented Oct 20, 2024

@duglin for review

@embano1 embano1 enabled auto-merge October 20, 2024 07:35
@@ -86,7 +86,7 @@ func (b *httpRequestWriter) setBody(body io.Reader) error {
default:
// This is where we'd set it to -1 (at least
// if body != NoBody) to mean unknown, but
// that broke people during the Go 1.8 testing
// that broke people during the Go 1.8 testin2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, but not by me :)

I need to file a README update, lemme quickly address

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duglin fixed

Signed-off-by: Michael Gasch <15986659+embano1@users.noreply.github.com>
Signed-off-by: Michael Gasch <15986659+embano1@users.noreply.github.com>
@embano1 embano1 merged commit 6632416 into cloudevents:main Oct 21, 2024
9 checks passed
@embano1 embano1 deleted the deps_go122 branch October 21, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants