Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch sarama_kafka rebalance fix #818

Merged
merged 4 commits into from
Nov 10, 2022
Merged

Patch sarama_kafka rebalance fix #818

merged 4 commits into from
Nov 10, 2022

Commits on Nov 3, 2022

  1. Patch sarama_kafka rebalance fix 

    Issue: cloudevents#817
Issue Explanation: IBM/sarama#2118
Fix reference: https://github.com/Shopify/sarama/blob/5e2c2ef0e429f895c86152189f625bfdad7d3452/examples/consumergroup/main.go#L177

Signed-off-by: nbajaj90 <nbajaj90@gmail.com>
    @nbajaj90
    nbajaj90 committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    01c4f13 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Adding comment as per code review comment 

    Signed-off-by: nbajaj90 <nbajaj90@gmail.com>
    @nbajaj90
    nbajaj90 committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    e9c865d View commit details
    Browse the repository at this point in the history

  2. Fixing typo 

    Signed-off-by: nbajaj90 <nbajaj90@gmail.com>
    @nbajaj90
    nbajaj90 committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    39c9aae View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. Incorporated review comment to move comment 

    Signed-off-by: nbajaj90 <nbajaj90@gmail.com>
    @nbajaj90
    nbajaj90 committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    f851877 View commit details
    Browse the repository at this point in the history