[Pages] Update bindings section of Qwik framework guide #12915
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jculvey
requested review from
GregBrimble,
WalshyDev and
a team
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
jculvey
changed the title
|
|
||
| ### Deploy via the Cloudflare dashboard | ||
| You can instead [connect a GitHub or Gitlab repository](/pages/configuration/git-integration) to your Pages project so that new versions of your project are built and deployed when changes to your git repository are detected. To do so, choose “No” when C3 asks if you’d like to deploy and refer to the guide below. |
There was a problem hiding this comment.
In the Next.js guide we went quite a different direction in regards to the git integration:
I think we should be consistent and use the Next.js version (which is the one the team agreed on I think)
There was a problem hiding this comment.
ok I can see the same sort of note below... but I think that this version is more confusing then the Next.js one since here we say "instead" and tell people to say "No" to the C3 deployment, and only later we mention the option to create a new Pages project. 🤔
dario-piotrowicz
force-pushed
the
jculvey/qwik-bindings-update
branch
from
a870b1d
to
12ea92f
Compare
Deploying with
|
| Latest commit: |
d3de783
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4114b86a.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://jculvey-qwik-bindings-update.cloudflare-docs-7ou.pages.dev |
|
Files with changes (up to 15) |
jculvey
force-pushed
the
jculvey/qwik-bindings-update
branch
from
12ea92f
to
d3de783
Compare
6 tasks
Comment on lines
+108
to
+112
| if(process.env.NODE_ENV === 'development') { | ||
| const { getBindingsProxy } = await import('wrangler'); | ||
| const { bindings } = await getBindingsProxy(); | ||
| env = bindings; | ||
| } |
There was a problem hiding this comment.
since #12957 got merged:
Suggested change
| if(process.env.NODE_ENV === 'development') { | |
| const { getBindingsProxy } = await import('wrangler'); | |
| const { bindings } = await getBindingsProxy(); | |
| env = bindings; | |
| } | |
| if(process.env.NODE_ENV === 'development') { | |
| const { getPlatformProxy } = await import('wrangler'); | |
| const platformProxy = await getBindingsProxy(); | |
| env = platformProxy.env; | |
| } |
(following what I did in cloudflare/workers-sdk#5010)
| }); | ||
| ``` | ||
|
|
||
| The `getBindingsProxy` [helper function](/workers/wrangler/api#getbindingsproxy) will automatically detect any bindings defined in the `wrangler.toml` file and emulate them in local development. See [Wrangler configuration](workers/wrangler/configuration/#bindings) for more information on how to configure bindings in `wrangler.toml`. |
There was a problem hiding this comment.
since #12957 got merged:
Suggested change
| The `getBindingsProxy` [helper function](/workers/wrangler/api#getbindingsproxy) will automatically detect any bindings defined in the `wrangler.toml` file and emulate them in local development. See [Wrangler configuration](workers/wrangler/configuration/#bindings) for more information on how to configure bindings in `wrangler.toml`. | |
| The `getPlatformProxy` [helper function](/workers/wrangler/api#getplatformproxy) will automatically detect any bindings defined in the `wrangler.toml` file and emulate them in local development. See [Wrangler configuration](workers/wrangler/configuration/#bindings) for more information on how to configure bindings in `wrangler.toml`. |
|
👋Hi there, we’re going to close this PR due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds more detail to the bindings section of the Qwik framework guide on how to configure bindings in dev and production. It covers the recent addition of
getBindingsProxyto the qwik template in c3: cloudflare/workers-sdk#4927.A few of the sections were re-ordered to bring the page in line with the proposed updates to the Next.js framework guide: #12707