[KV] Wrangler-KV Command Update #16400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oxyjun
requested review from
penalosa,
petebacondarwin,
dario-piotrowicz,
irvinebroque,
GregBrimble,
a team,
elithrar,
thomasgauvin,
rts-rob and
kodster28
as code owners
|
There is currently one pending issue - when the "source of truth" KV commands are rendered in the list of all Wrangler commands, the table of headings on the RHS fails to register duplicated header names. There are several workarounds for this, but these changes need to be properly discussed with PCX. |
Deploying cloudflare-docs with
|
| Latest commit: |
3f93dc8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d09fdaf1.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://kv-jun-wrangler-command-upda.cloudflare-docs-7ou.pages.dev |
github-actions
bot
added
size/xl
product:kv
product:workers
thomasgauvin
approved these changes
Sep 4, 2024
I think this has been solved, so good to merge? |
pedrosousa
approved these changes
Sep 5, 2024
|
|
||
| :::caution | ||
|
|
||
| This command requires `--binding` or `--namespace-id`. |
There was a problem hiding this comment.
Nit: Currently we write this warning in three different ways along the page:
- This command requires --binding or --namespace-id.
- This command requires a --binding or --namespace-id flag.
- Exactly one of --binding or --namespace-id is required.
Co-authored-by: Pedro Sousa <680496+pedrosousa@users.noreply.github.com>
Co-authored-by: Pedro Sousa <680496+pedrosousa@users.noreply.github.com>
elithrar
pushed a commit
that referenced
this pull request
Oct 15, 2024
* Updating Wrangler commands related to KV. * Updating KV-specific wrangler docs. Porting PR. * Correcting syntax so the partial works. * Update src/content/partials/workers/wrangler-commands/kv.mdx Co-authored-by: Pedro Sousa <680496+pedrosousa@users.noreply.github.com> * Update src/content/partials/workers/wrangler-commands/kv.mdx Co-authored-by: Pedro Sousa <680496+pedrosousa@users.noreply.github.com> --------- Co-authored-by: Pedro Sousa <680496+pedrosousa@users.noreply.github.com>
maheshwarip
pushed a commit
that referenced
this pull request
Dec 2, 2024
* Updating Wrangler commands related to KV. * Updating KV-specific wrangler docs. Porting PR. * Correcting syntax so the partial works. * Update src/content/partials/workers/wrangler-commands/kv.mdx Co-authored-by: Pedro Sousa <680496+pedrosousa@users.noreply.github.com> * Update src/content/partials/workers/wrangler-commands/kv.mdx Co-authored-by: Pedro Sousa <680496+pedrosousa@users.noreply.github.com> --------- Co-authored-by: Pedro Sousa <680496+pedrosousa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Continuation of the PR from: #15985
TLDR of this current PR:
partials/workers/wrangler-commands/kv.mdx. This is the single source of truth for Wrangler-KV commands.docs/workers/wrangler/commands.mdx.docs/kv/kv-commands.mdx.docs/workers/wrangler/commands.mdxhas been used over the other.Screenshots (optional)
Documentation checklist