Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Replace insecure JS library" to brotli-compression-warning.mdx #16402

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

xuhdev
Copy link
Contributor

@xuhdev xuhdev commented Aug 22, 2024

Based on discussion at https://community.cloudflare.com/t/cloudflare-not-serving-pre-compressed-brotli-from-the-origin/701864/3, looks like "Replace Inssecure JS Library" also must be disabled for end-to-end compression to work.

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

Based on discussion at https://community.cloudflare.com/t/cloudflare-not-serving-pre-compressed-brotli-from-the-origin/701864/3, looks like "Replace Inssecure JS Library" also must be disabled for end-to-end compression to work.
@github-actions github-actions bot added size/s and removed size/xs labels Sep 2, 2024
@pedrosousa
Copy link
Contributor

Hi @xuhdev
We actually updated the entire section because it was slightly outdated... Thank you for your contribution!

@pedrosousa pedrosousa self-assigned this Sep 2, 2024
@pedrosousa pedrosousa merged commit d9e7e79 into cloudflare:production Sep 2, 2024
6 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes a docs contribution, big or small label Sep 2, 2024
Copy link

holopin-bot bot commented Sep 2, 2024

Congratulations @xuhdev, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm0l8k09010990cldph53gevt

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@xuhdev xuhdev deleted the patch-4 branch September 2, 2024 18:23
elithrar pushed a commit that referenced this pull request Oct 15, 2024
…ng.mdx (#16402)

---------

Co-authored-by: Pedro Sousa <680496+pedrosousa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes a docs contribution, big or small size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants