Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certificate_packs: deprecate "custom" in favour of ACM #1032

Merged

Conversation

jacobbednarz
Copy link
Member

Triggered by cloudflare/cf-terraforming#443 validation mismatches, I
went ahead and updated CertificatePacks to only reference ACM
configuration now that dedicated custom/custom certificates are no more.

Triggered by cloudflare/cf-terraforming#443 validation mismatches, I
went ahead and updated `CertificatePacks` to only reference ACM
configuration now that dedicated custom/custom certificates are no more.
@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2022

changelog detected ✅

@jacobbednarz
Copy link
Member Author

@nickysemenza do you mind eyeballing this one for me? we had some failures in cf-terraforming which lead me here to clean up the structs and methods.

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2022

Codecov Report

Merging #1032 (50eb00b) into master (6c5ea4a) will increase coverage by 0.08%.
The diff coverage is 58.87%.

@@            Coverage Diff             @@
##           master    #1032      +/-   ##
==========================================
+ Coverage   49.06%   49.14%   +0.08%     
==========================================
  Files         108      111       +3     
  Lines       10428    10516      +88     
==========================================
+ Hits         5116     5168      +52     
- Misses       4200     4224      +24     
- Partials     1112     1124      +12     
Impacted Files Coverage Δ
access_application.go 76.52% <ø> (ø)
access_bookmark.go 72.44% <ø> (ø)
workers_account_settings.go 35.71% <35.71%> (ø)
workers_tail.go 52.00% <52.00%> (ø)
certificate_packs.go 50.90% <71.42%> (+0.16%) ⬆️
r2_bucket.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jacobbednarz jacobbednarz merged commit 0b696fd into cloudflare:master Aug 17, 2022
@jacobbednarz jacobbednarz deleted the expand-certificate-pack-struct branch August 17, 2022 09:24
@github-actions github-actions bot added this to the v0.47.0 milestone Aug 17, 2022
github-actions bot pushed a commit that referenced this pull request Aug 17, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v0.47.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants