Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Blockpage.SuppressFooter field #1053

Merged

Conversation

NicholasAsimov
Copy link
Contributor

Description

Cloudflare documentation for TeamsAccount blockpage settings exposes suppress_footer field.
https://api.cloudflare.com/#zero-trust-accounts-update-zero-trust-account-configuration

Has your change been tested?

Updated relevant test in teams_accounts.go.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

teams_accounts.go Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2022

changelog detected ✅

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2022

Codecov Report

Merging #1053 (b803b6a) into master (6c5ea4a) will increase coverage by 0.88%.
The diff coverage is 62.94%.

@@            Coverage Diff             @@
##           master    #1053      +/-   ##
==========================================
+ Coverage   49.06%   49.94%   +0.88%     
==========================================
  Files         108      115       +7     
  Lines       10428    10991     +563     
==========================================
+ Hits         5116     5490     +374     
- Misses       4200     4338     +138     
- Partials     1112     1163      +51     
Impacted Files Coverage Δ
access_application.go 76.52% <ø> (ø)
access_bookmark.go 72.44% <ø> (ø)
teams_accounts.go 53.84% <ø> (ø)
workers_account_settings.go 35.71% <35.71%> (ø)
rulesets.go 35.09% <47.36%> (+7.43%) ⬆️
workers_tail.go 52.00% <52.00%> (ø)
workers_subdomain.go 57.14% <57.14%> (ø)
email_routing_settings.go 60.00% <60.00%> (ø)
email_routing_rules.go 65.64% <65.64%> (ø)
lockdown.go 57.69% <66.00%> (+6.94%) ⬆️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jacobbednarz
Copy link
Member

once a CHANGELOG is added, I'm 👍

@jacobbednarz jacobbednarz merged commit 5c68ab9 into cloudflare:master Aug 22, 2022
@github-actions github-actions bot added this to the v0.48.0 milestone Aug 22, 2022
github-actions bot pushed a commit that referenced this pull request Aug 22, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v0.48.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants