Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pages deployment auto pagination #1264

Merged

Conversation

Cyb3r-Jak3
Copy link
Contributor

@Cyb3r-Jak3 Cyb3r-Jak3 commented Apr 7, 2023

Description

Adds support for auto paginate for pages deployments. Support forcing deletion of a pages deployment.
Also removed an unused type and var.

Has your change been tested?

Updated existing tests and they pass.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

changelog detected ✅

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2023

Codecov Report

Merging #1264 (ce92b12) into master (0c3db86) will increase coverage by 0.16%.
The diff coverage is 66.29%.

@@            Coverage Diff             @@
##           master    #1264      +/-   ##
==========================================
+ Coverage   49.23%   49.40%   +0.16%     
==========================================
  Files         131      131              
  Lines       12665    12719      +54     
==========================================
+ Hits         6236     6284      +48     
+ Misses       4988     4985       -3     
- Partials     1441     1450       +9     
Impacted Files Coverage Δ
access_organization.go 64.70% <ø> (ø)
access_policy.go 76.31% <ø> (ø)
errors.go 40.78% <ø> (ø)
rulesets.go 34.64% <0.00%> (-0.35%) ⬇️
ssl.go 72.72% <ø> (ø)
zone.go 41.70% <50.00%> (+2.59%) ⬆️
pages_deployment.go 38.88% <60.60%> (+4.64%) ⬆️
pages_project.go 60.52% <100.00%> (+9.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

pages_deployment.go Outdated Show resolved Hide resolved
@Cyb3r-Jak3 Cyb3r-Jak3 force-pushed the pages-deployment-autoPaginate branch from d9fb7d1 to 7376c32 Compare April 16, 2023 19:02
pagination.go Outdated Show resolved Hide resolved
@Cyb3r-Jak3 Cyb3r-Jak3 force-pushed the pages-deployment-autoPaginate branch from 7376c32 to 1e74748 Compare April 17, 2023 00:12
@gitguardian
Copy link

gitguardian bot commented Apr 19, 2023

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@Cyb3r-Jak3
Copy link
Contributor Author

I don't know what the plan is for the project name test, I know that the API will reject it if you try. Also, total_pages is now in the API response for listing deployments.

Pages, unfortunately, uses a friendly name for the identifier in the URL
so to be able to update the `Name` value we need a way to differentiate
the two. The way I've solved this here is that `ID` is used for
addressing the resource via the UI or a stable identifier whereas `Name`
is used for updating the value.
@jacobbednarz jacobbednarz merged commit 845abcd into cloudflare:master Jul 7, 2023
@github-actions github-actions bot added this to the v0.73.0 milestone Jul 7, 2023
github-actions bot pushed a commit that referenced this pull request Jul 7, 2023
@Cyb3r-Jak3 Cyb3r-Jak3 deleted the pages-deployment-autoPaginate branch July 7, 2023 20:54
@github-actions
Copy link
Contributor

This functionality has been released in v0.73.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants