Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add per-hostname tls settings api and tests #1356

Conversation

vasilzhigilei
Copy link
Contributor

@vasilzhigilei vasilzhigilei commented Aug 3, 2023

Description

Per-Hostname TLS Settings is a new API where customers can set TLS settings on a per-hostname basis while not being coupled to any specific certificate. SSL/TLS team.

Has your change been tested?

Added unit tests.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

changelog detected ✅

… the rest of the tls settings due to unique response structure
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Merging #1356 (fb3ee89) into master (b9ac804) will increase coverage by 0.11%.
Report is 136 commits behind head on master.
The diff coverage is 49.04%.

@@            Coverage Diff             @@
##           master    #1356      +/-   ##
==========================================
+ Coverage   48.33%   48.45%   +0.11%     
==========================================
  Files         133      137       +4     
  Lines       13023    13368     +345     
==========================================
+ Hits         6295     6477     +182     
- Misses       5201     5310     +109     
- Partials     1527     1581      +54     
Files Changed Coverage Δ
access_application.go 72.72% <ø> (ø)
access_organization.go 53.84% <ø> (ø)
device_posture_rule.go 61.80% <ø> (ø)
load_balancing.go 59.40% <ø> (ø)
teams_accounts.go 53.84% <ø> (ø)
workers.go 63.15% <ø> (+3.69%) ⬆️
rulesets.go 30.46% <28.20%> (-4.18%) ⬇️
per_hostname_tls_settings.go 32.43% <32.43%> (ø)
logpush.go 51.81% <42.55%> (-0.30%) ⬇️
regional_tiered_cache.go 43.75% <43.75%> (ø)
... and 7 more

... and 111 files with indirect coverage changes

@jacobbednarz jacobbednarz merged commit dc111b0 into cloudflare:master Aug 10, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.75.0 milestone Aug 10, 2023
github-actions bot pushed a commit that referenced this pull request Aug 10, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.75.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants