-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for additional cacheable ports in the Rulesets API #1375
Add support for additional cacheable ports in the Rulesets API #1375
Conversation
ResponseFields []RulesetActionParametersLogCustomField `json:"response_fields,omitempty"` | ||
CookieFields []RulesetActionParametersLogCustomField `json:"cookie_fields,omitempty"` | ||
Cache *bool `json:"cache,omitempty"` | ||
AdditionalCacheablePorts []int `json:"additional_cacheable_ports,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of this is whitespace formatting, this is the only new field
49ffaa6
to
6eb7e52
Compare
changelog detected ✅ |
In regards to public documentation, ref: #1374 (comment) |
Codecov Report
@@ Coverage Diff @@
## master #1375 +/- ##
========================================
Coverage 48.33% 48.34%
========================================
Files 133 139 +6
Lines 13023 13749 +726
========================================
+ Hits 6295 6647 +352
- Misses 5201 5453 +252
- Partials 1527 1649 +122
|
LGTM once the API schemas are present. (ping me once they are ready and we can hit the big green button) |
This functionality has been released in v0.76.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Adds support for the usage of the
additional_cacheable_ports
field which has been added to the rulesets API. This allows the origin to pass content back on non-standard ports that are eligible for caching.Has your change been tested?
Thoroughly tested at the API level, unit tests modifications included for the library.
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.