-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Consecutive_up and Consecutive_down for load_balancer_monitor res… #1380
Conversation
changelog detected ✅ |
Codecov Report
@@ Coverage Diff @@
## master #1380 +/- ##
========================================
Coverage 48.33% 48.34%
========================================
Files 133 139 +6
Lines 13023 13749 +726
========================================
+ Hits 6295 6647 +352
- Misses 5201 5453 +252
- Partials 1527 1649 +122
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR. looks good overall but we should use camel casing for the struct names.
This functionality has been released in v0.76.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
We can set the consecutive_down and consecutive_up parameter values for the Cloudflare Load Balancer Monitor via API but not via terraform.
Issue from terraform-provider-cloudflare
Has your change been tested?
Yes, relevant unit tests have been updated to handle the addition of this field. Additionally, changes were ran against the pre-existing test suite to verify that no regressions were introduced.
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.