-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add gateway categories #2722
Feat/add gateway categories #2722
Conversation
Signed-off-by: Brenno Oliveira <brenno.oliveira@deliveryhero.com>
Signed-off-by: Brenno Oliveira <brenno.oliveira@deliveryhero.com>
changelog detected ✅ |
Signed-off-by: Brenno Oliveira <brenno.oliveira@deliveryhero.com>
this functionality already exists in |
Co-authored-by: Jacob Bednarz <jacob.bednarz@hey.com>
no specific reason, I think when I was going thru the provider code I read somewhere that v2 should not be used |
you may have misunderstood; the Terraform SDKv2 shouldn't be used. the v2 Go library is where we are moving towards. we can merge this since it's already done but the Terraform provider should use v2 where possible (as that is what we're using going forward). |
yep it is clear to me I mixed the V2s - if you think there is value in it feel free to merge - I will get back to the provider and when I start something I will use V2 Go library thanks Jacob! |
This functionality has been released in v0.100.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
This pull request adds support for the
ListGatewayCategories
endpoint.Description
Our main driver is that we are looking into have this data available as a data resource in the terraform provider, please let me know if this is the right direction.
Has your change been tested?
besides the test case I created this script and the output seems correct
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.