Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add gateway categories #2722

Merged
merged 5 commits into from
Jul 4, 2024

Conversation

brennoo
Copy link
Contributor

@brennoo brennoo commented Jul 3, 2024

This pull request adds support for the ListGatewayCategories endpoint.

Description

Our main driver is that we are looking into have this data available as a data resource in the terraform provider, please let me know if this is the right direction.

Has your change been tested?

besides the test case I created this script and the output seems correct

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

Signed-off-by: Brenno Oliveira <brenno.oliveira@deliveryhero.com>
Signed-off-by: Brenno Oliveira <brenno.oliveira@deliveryhero.com>
Copy link
Contributor

github-actions bot commented Jul 3, 2024

changelog detected ✅

Signed-off-by: Brenno Oliveira <brenno.oliveira@deliveryhero.com>
.changelog/2722.txt Outdated Show resolved Hide resolved
@jacobbednarz
Copy link
Member

this functionality already exists in v2 - is there a reason why we cannot use that instead?

Co-authored-by: Jacob Bednarz <jacob.bednarz@hey.com>
@brennoo
Copy link
Contributor Author

brennoo commented Jul 4, 2024

this functionality already exists in v2 - is there a reason why we cannot use that instead?

no specific reason, I think when I was going thru the provider code I read somewhere that v2 should not be used

@jacobbednarz
Copy link
Member

you may have misunderstood; the Terraform SDKv2 shouldn't be used. the v2 Go library is where we are moving towards.

we can merge this since it's already done but the Terraform provider should use v2 where possible (as that is what we're using going forward).

@brennoo
Copy link
Contributor Author

brennoo commented Jul 4, 2024

yep it is clear to me I mixed the V2s - if you think there is value in it feel free to merge - I will get back to the provider and when I start something I will use V2 Go library

thanks Jacob!

@jacobbednarz jacobbednarz merged commit 8643509 into cloudflare:master Jul 4, 2024
9 of 10 checks passed
@github-actions github-actions bot added this to the v0.100.0 milestone Jul 4, 2024
@brennoo brennoo deleted the feat/add_gateway_categories branch July 5, 2024 06:14
Copy link
Contributor

This functionality has been released in v0.100.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants