Add automatic ssl mode setting support #2855
Conversation
|
changelog detected ✅ |
yj7o5
force-pushed
the
automatic-ssl-to-origin
branch
from
6359a4e
to
a36975d
Compare
yj7o5
changed the title
zone.go
Outdated
| // UpdateZoneAutomaticSSLSettingMode update information about Automatic SSL mode setting to the specified zone. | ||
| // | ||
| // API reference: https://api.cloudflare.com/[#-add-url-slug-here] | ||
| func (api *API) UpdateZoneAutomaticSSLSettingMode(ctx context.Context, zoneID, mode string) (ZoneSSLSetting, error) { |
There was a problem hiding this comment.
we already have a method for fetching/updating zone settings (https://github.com/cloudflare/cloudflare-go/blob/master/zone.go#L958). is there a reason we cannot reuse that here?
There was a problem hiding this comment.
Correct, however, there is a slight difference in the response we return for this specific setting. As it returns a field called next_scheduled_scan: https://github.com/cloudflare/cloudflare-go/pull/2855/files#diff-ceb3700215079abfa8dfc51b35af780ed6292f4747db0d4710c6c72de18a0a66R178
Also I think the return type here should reference the ZoneAutomaticSSLModeSetting struct vs ZoneSSLSetting. Will fix that typo.
There was a problem hiding this comment.
you could always put it in a pointer with omitempty which will conditionally set it when it is provided.
There was a problem hiding this comment.
in the generated version of the libraries, these endpoints are flattened into a single struct so that would make sense to reflect here too if possible.
There was a problem hiding this comment.
updated to use the existing Get/UpdateZoneSettings construct and added the field as part of the ZoneSetting struct with omitempty markup
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
This functionality has been released in v0.104.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
This PR adds support for reading and modifying the new automatic ssl mode setting.
Has your change been tested?
Yes, there are tests in placed to verify both reading and writing the setting value.
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.