Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QueueConsumer to reflect the API #3023

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

76creates
Copy link

Description

Hello team,

Im currently working on making cloudflare/terraform-provider-cloudflare#3833 possible. Ive noticed that there are fields missing from the QueueConsumer and QueueConsumerSettings. Ive proceeded to add them, and also took consumer_id for Name input, which Im not sure is proper at the moment, Ill update if needed.

Please write to me for any additional changes needed, Im first time commiter on this repo.

Has your change been tested?

Ive tested it with the TF provider resources Im writing for the queue consumers.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

feature: add missing fields on the queue consumer
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/cloudflare-go/blob/master/docs/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included, please add the workflow/skip-changelog-entry label.

@jacobbednarz
Copy link
Member

these fields are not documented as publicly stable so i'm afraid we cannot merge this as is.

@76creates
Copy link
Author

these fields are not documented as publicly stable so i'm afraid we cannot merge this as is.

Do you have a schedule/cycles for maturing the API? If not, do you have a personal estimate? Just to have as a compass.

@jacobbednarz
Copy link
Member

attributes and endpoints are documented when the service team believes they have reached the maturity level where they can commit to a public contract. it's very team and product dependent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants