Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CRUD endpoints for Infrastructure Access Targets #3184

Merged

Conversation

SaiDadireddy
Copy link
Contributor

@SaiDadireddy SaiDadireddy commented Sep 19, 2024

Description

We are recently added new endpoints for infrastructure access. We are looking to get these endpoints reflected in the terraform provider documentation. This PR contains the client side changes necessary for that. It writes CRUDL functions for the terraform provider to interact with our new endpoints.

Our OpenAPI schema is published in cloudflare/api-schemas viewable in this commit
Our API docs are accessible in production at https://developers.cloudflare.com/api/operations/infra-targets-list

Has your change been tested?

I've tested these changes through acceptance tests.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

infrastructure_targets.go Outdated Show resolved Hide resolved
infrastructure_targets.go Outdated Show resolved Hide resolved
jacobbednarz and others added 3 commits September 23, 2024 12:32
Signed-off-by: Jacob Bednarz <jacob.bednarz@gmail.com>
Signed-off-by: Jacob Bednarz <jacob.bednarz@gmail.com>
@SaiDadireddy SaiDadireddy changed the title Add CRUD endpoints for infrastructure access endpoints Add CRUD endpoints for Infrastructure Access Targets Sep 23, 2024
@jacobbednarz jacobbednarz merged commit 00e4dd3 into cloudflare:master Sep 25, 2024
9 of 10 checks passed
@github-actions github-actions bot added this to the v0.105.0 milestone Sep 25, 2024
Copy link
Contributor

This functionality has been released in v0.105.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants