Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Speed Brain #3233

Closed
wants to merge 1 commit into from
Closed

Conversation

cf-ypark
Copy link

Description

Add support for Speed Brain feature

Has your change been tested?

Unit tests have been added that align with the documented API spec.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this OK to be placed in root, not under /internal ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason why it should fall under /internal?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking at different repo.

@cf-ypark
Copy link
Author

not sure why changelog-check is failing @jacobbednarz any help?

@jacobbednarz
Copy link
Member

jacobbednarz commented Sep 23, 2024

i don't think we need this PR as it would already be supported using https://github.com/cloudflare/cloudflare-go/blob/master/zone.go#L928-L985. terraform we should just be able to add the key to the array have this Just Work™

@cf-ypark
Copy link
Author

got it, @jacobbednarz I'll close this one then. thanks!

@cf-ypark cf-ypark closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants